Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): properly attach / detach child video controller #13876

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

hansemannn
Copy link
Collaborator

Fixes #13612

@m1ga
Copy link
Contributor

m1ga commented Jun 28, 2023

I couldn't reproduce the initial issue but with this PR the volume/fullscreen controls are not behind the bar anymore

before:
Simulator Screenshot - iPhone 14 Pro Max - 2023-06-28 at 14 24 14

after:
Simulator Screenshot - iPhone 14 Pro Max - 2023-06-28 at 14 27 02

so that is already an improvement. Tested on iOS 16 emulator/device

@hansemannn hansemannn merged commit 6195261 into tidev:master Jul 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS 16: Default video controls missing
2 participants